Fix #6277 #6330
Merged
Fix #6277 #6330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypeSubtypeOf like the old code
Member
There was a problem hiding this comment.
This comment should be updated. It's only sort-of true now that there are up to two decisions made before returning.
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively, all I did was stop looking for
anyspecifically to narrow to the primitive and went back to usingisTypeSubtypeOf- not sure why it was changed to begin with (if I had to guess it would be because while implementing I forgot that even primitives are technically structural and can be the subtype of other things), but now we have tests showing areas where the difference matters!Edit by @DanielRosenwasser: Fixes #6277.